Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in OpCodes.sol #1051

Closed

Conversation

eltociear
Copy link

begining -> beginning

@dominant-strategies/core-dev

begining -> beginning
Copy link
Member

@wizeguyy wizeguyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these :)

@wizeguyy
Copy link
Member

@eltociear your PR is a few commits behind latest. Could you please rebase your PR onto latest main? I will merge it once you do.

Copy link
Contributor

@Djadih Djadih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are great! Please just drop the merge commit and only keep the second one (and dont forget to rebase on latest main) and then this will be good to merge.

@Djadih
Copy link
Contributor

Djadih commented Sep 1, 2023

Closing PR as its outdated. This file has been removed entirely.

@Djadih Djadih closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants